72759[TASK] Allow EXT: syntax in f:uri.resource VH
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Helmut Hummel +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1722
-
Christian Kuhn uploaded patch set 1 12/21/21, 11:32
-
core-ci voted on patch set 1 V -1 12/21/21, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21347
-
Christian Kuhn uploaded patch set 2 12/21/21, 11:45
-
Christian Kuhn updated the commit message in patch set 3 12/21/21, 11:47
-
Christian Kuhn commented on patch set 3 12/21/21, 11:48
note the v11 backport will skip strict_types. -
Christian Kuhn commented on patch set 3 12/21/21, 11:55
And the backport will skip the exception (this is a part of an upcoming patch for main and i'm too lazy to rebase this detail ;) -
core-ci voted on patch set 2 V +1 12/21/21, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21348
-
core-ci voted on patch set 3 V +1 12/21/21, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21349
-
Stefan Bürk voted on patch set 3 V +1 CR +1 12/21/21, 12:08
-
Helmut Hummel commented on patch set 3 CR -1 12/21/21, 12:31
ResourceViewHelper.php:95Please use \TYPO3\CMS\Core\Utility\PathUtility::isExtensionPath insteadResourceViewHelper.php:98To avoid this if/else construct, I'd refactor this into a private (static) method with early returns -
Christian Kuhn commented on patch set 3 12/21/21, 12:38
ResourceViewHelper.php:95Replyah. good one. was unaware of this.ResourceViewHelper.php:98ReplyWell, that's matter of taste. I'd rather keep the code straight in one method. I think it's pretty easy to read and grasp as it is now. -
Christian Kuhn uploaded patch set 4 12/21/21, 12:38
-
Stefan Bürk voted on patch set 4 V +1 CR +1 12/21/21, 12:43
-
core-ci voted on patch set 4 V +1 12/21/21, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21353
-
Helmut Hummel commented on patch set 4 CR -1 12/21/21, 13:52
on it -
Helmut Hummel uploaded patch set 5 12/21/21, 14:56
-
Helmut Hummel voted on patch set 5 V +1 CR +1 12/21/21, 15:04
-
core-ci voted on patch set 5 V +1 12/21/21, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21355
-
Christian Kuhn voted on patch set 5 V +1 CR +1 12/21/21, 15:16
-
Stefan Bürk voted on patch set 5 V +1 CR +1 12/21/21, 15:18
-
Christian Kuhn voted on patch set 5 V +2 CR +2 12/21/21, 15:21
-
Christian Kuhn merged patch set 6 12/21/21, 15:21