Review 11.5 Merged

72760[TASK] Allow EXT: syntax in f:uri.resource VH

Christian Kuhn CR +2 V +2 Normal +202 −20 updated 12/21/21, 16:24

Commit message

f:uri.resource is frequently used to load CSS and
JavaScript resources. It is the only ViewHelper that
does not understand the general "EXT:" syntax that
is usually available when extension resource files
are referenced.

This is now added to improve consistency and
documented as best practice in VH documentation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Christian Kuhn uploaded patch set 1 12/21/21, 11:58

  2. Christian Kuhn uploaded patch set 2 12/21/21, 11:58

  3. core-ci voted on patch set 1 V -1 12/21/21, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21350

  4. core-ci voted on patch set 2 V +1 12/21/21, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21351

  5. Stefan Bürk commented on patch set 2 12/21/21, 12:35

    ResourceViewHelper.php:74

    Is adding the return type here not eventually breaking, if some still extends from this viewhelper in v11 ?
  6. Christian Kuhn commented on patch set 2 12/21/21, 12:39

    ResourceViewHelper.php:74 Reply

    well ... mmmh ... ok, i'll drop it. shouldn't be a real issue, though.
  7. Christian Kuhn uploaded patch set 3 12/21/21, 12:41

  8. Stefan Bürk commented on patch set 3 V +1 CR +1 12/21/21, 12:43

    ResourceViewHelper.php:74 Reply

    Done
  9. core-ci voted on patch set 3 V +1 12/21/21, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21354

  10. Christian Kuhn uploaded patch set 4 12/21/21, 15:24

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 12/21/21, 15:26

  12. core-ci voted on patch set 4 V -1 12/21/21, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21357

  13. Christian Kuhn uploaded patch set 5 12/21/21, 16:02

  14. core-ci voted on patch set 5 V +1 12/21/21, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21361

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 12/21/21, 16:23

  16. Christian Kuhn voted on patch set 5 V +2 CR +2 12/21/21, 16:24

  17. Christian Kuhn merged patch set 6 12/21/21, 16:24