Review main Merged

72762[BUGFIX] Avoid PHP8 warning for "Insert records" with hidden records

Chris Müller CR +2 V +2 Easy +4 −1 updated 12/21/21, 16:30

Commit message

When one or more hidden records are referenced in an "Insert records"
content element, an "undefined array key" warning was thrown.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Chris Müller uploaded patch set 1 12/21/21, 15:40

  2. core-ci voted on patch set 1 V +1 12/21/21, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21358

  3. Benni Mack commented on patch set 2 12/21/21, 16:09

    Published edit on patch set 1.
  4. Benni Mack voted on patch set 2 V +1 CR +1 12/21/21, 16:09

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 12/21/21, 16:23

  6. core-ci voted on patch set 2 V +1 12/21/21, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21363

  7. Benni Mack voted on patch set 2 V +2 CR +2 12/21/21, 16:29

  8. Benni Mack merged patch set 3 12/21/21, 16:30