Review main Merged

72768[TASK] Migrate FormEngine and FormEngineValidation to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +2253 −2184 updated 01/03/22, 16:14

Commit message

A human-readable diff of the applied changes can be inspected on:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.ts
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.ts

Notes:

 * No major refactoring to keep the diff minimal and prepare behaviour
   as-is
 * Map imports to require-style
 * Added default sections in switch statements
 * Guard parseInt and Date.parse with typeof/instanceof
 * Use event.eventTarget instead of this in jQuery event callbacks
 * Use second method parameter in jQuery.each callbacks
 * Add @ts-ignore and eslint-disable-next-line where TypeScript
   adaptions aren't possible without possibly changing behaviour

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 12/21/21, 23:00

  2. Benjamin Franzke uploaded patch set 2 12/21/21, 23:02

  3. core-ci voted on patch set 1 V -1 12/21/21, 23:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21379

  4. core-ci voted on patch set 2 V +1 12/21/21, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21380

  5. Benjamin Franzke wrote 12/21/21, 23:32

    Topic set to esm
  6. Benjamin Franzke updated the commit message in patch set 3 12/21/21, 23:33

  7. core-ci voted on patch set 3 V +1 12/21/21, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21381

  8. Benjamin Franzke commented on patch set 3 CR -1 12/22/21, 09:22

    Should ideally also adapt typo3/sysext/backend/Resources/Public/JavaScript/FormEngineLinkBrowserAdapter.js and resolve https://forge.typo3.org/issues/82586 and https://forge.typo3.org/issues/82590
  9. Benjamin Franzke updated the commit message in patch set 4 12/22/21, 14:07

  10. Benjamin Franzke commented on patch set 4 12/22/21, 14:07

    Reply

    Will add a separate patch for FormEngineLinkBrowserAdapter.js
  11. core-ci voted on patch set 4 V +1 12/22/21, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21398

  12. Benni Mack voted on patch set 4 V +1 CR +1 12/22/21, 17:17

  13. Benjamin Franzke commented on patch set 4 CR -1 12/30/21, 13:21

  14. Andreas Kienast uploaded patch set 5 12/30/21, 13:53

  15. core-ci voted on patch set 5 V +1 12/30/21, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21517

  16. Benni Mack voted on patch set 5 V +1 CR +1 12/30/21, 15:36

  17. Oli Bartsch commented on patch set 5 V +1 CR +1 01/03/22, 13:59

    Styleguide examples, e.g. tx_styleguide_required, seem to work as expected.
  18. Benjamin Franzke voted on patch set 5 V +2 CR +2 01/03/22, 16:14

  19. Benjamin Franzke merged patch set 6 01/03/22, 16:14