72768[TASK] Migrate FormEngine and FormEngineValidation to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.tsnew+1228 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.tsnew+1013 −0
- Build/types/TYPO3/index.d.ts+10 −4
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+1 −1197
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+1 −983
Review log 1419
-
Benjamin Franzke uploaded patch set 1 12/21/21, 23:00
-
Benjamin Franzke uploaded patch set 2 12/21/21, 23:02
-
core-ci voted on patch set 1 V -1 12/21/21, 23:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21379
-
core-ci voted on patch set 2 V +1 12/21/21, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21380
-
Benjamin Franzke wrote 12/21/21, 23:32
Topic set to esm -
Benjamin Franzke updated the commit message in patch set 3 12/21/21, 23:33
-
core-ci voted on patch set 3 V +1 12/21/21, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21381
-
Benjamin Franzke commented on patch set 3 CR -1 12/22/21, 09:22
Should ideally also adapt typo3/sysext/backend/Resources/Public/JavaScript/FormEngineLinkBrowserAdapter.js and resolve https://forge.typo3.org/issues/82586 and https://forge.typo3.org/issues/82590 -
Benjamin Franzke updated the commit message in patch set 4 12/22/21, 14:07
-
Benjamin Franzke commented on patch set 4 12/22/21, 14:07
Reply
Will add a separate patch for FormEngineLinkBrowserAdapter.js -
core-ci voted on patch set 4 V +1 12/22/21, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21398
-
Benni Mack voted on patch set 4 V +1 CR +1 12/22/21, 17:17
-
Benjamin Franzke commented on patch set 4 CR -1 12/30/21, 13:21
Needs rebase because of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72806 -
Andreas Kienast uploaded patch set 5 12/30/21, 13:53
-
core-ci voted on patch set 5 V +1 12/30/21, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21517
-
Benni Mack voted on patch set 5 V +1 CR +1 12/30/21, 15:36
-
Oli Bartsch commented on patch set 5 V +1 CR +1 01/03/22, 13:59
Styleguide examples, e.g. tx_styleguide_required, seem to work as expected. -
Benjamin Franzke voted on patch set 5 V +2 CR +2 01/03/22, 16:14
-
Benjamin Franzke merged patch set 6 01/03/22, 16:14