Review main Merged

72771[TASK] Correct order of extbase view setup

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 12/22/21, 13:58

Commit message

With the removal of ControllerContext a view
init call had to be moved out of ControllerContext.
It was moved to a wrong place in the view setup
chain. This is fixed by the patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 12/22/21, 12:48

  2. Christian Kuhn updated the commit message in patch set 2 12/22/21, 12:48

  3. Markus Klein voted on patch set 2 V +1 CR +1 12/22/21, 12:57

  4. Benni Mack voted on patch set 2 V +1 CR +1 12/22/21, 13:04

  5. core-ci voted on patch set 2 V +1 12/22/21, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21395

  6. core-ci voted on patch set 1 V +1 12/22/21, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21394

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 12/22/21, 13:58

  8. Christian Kuhn merged patch set 3 12/22/21, 13:58