Review 11.5 Merged

72781[TASK] Add allowed composer plugins for composer >= 2.2.0

Georg Ringer CR +2 V +2 Easy +6 −1 updated 01/03/22, 15:42

Commit message

Added the following Composer plugins as allowed/trusted

* composer/package-versions-deprecated
* typo3/class-alias-loader
* typo3/cms-composer-installers

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Georg Ringer commented on patch set 1 12/23/21, 12:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/23/21, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21423

  3. Oliver Klee voted on patch set 1 CR +1 12/23/21, 14:26

  4. Stefan Froemken commented on patch set 1 V -1 12/23/21, 20:52

    After cherry-picking the patch on current master following Test will not work anymore: ➜ TYPO3.CMS git:(25a0815b82) Build/Scripts/runTests.sh -s functional -p 8.0 typo3/sysext/core/Tests/Functional/Authentication/ Consider installing realpath for properly resolving symlinks Using driver: mysqli Creating network "local_default" with the default driver Creating local_redis4_1 ... done Creating local_mariadb_1 ... done Creating local_memcached1-5_1 ... done Creating local_prepare_functional_mariadb_run ... done Waiting for database start... Database is up Creating local_functional_mariadb_run ... done PHP 8.0.14 (cli) (built: Dec 18 2021 02:58:33) ( NTS ) PHPUnit 9.5.10 by Sebastian Bergmann and contributors. PHP Fatal error: Class TYPO3\CMS\Core\Database\Driver\PDOConnection may not inherit from final class (Doctrine\DBAL\Driver\PDO\Connection) in /Users/froemken/htdocs/docker/typo3_git/TYPO3.CMS/typo3/sysext/core/Classes/Database/Driver/PDOConnection.php on line 28 Fatal error: Class TYPO3\CMS\Core\Database\Driver\PDOConnection may not inherit from final class (Doctrine\DBAL\Driver\PDO\Connection) in /Users/froemken/htdocs/docker/typo3_git/TYPO3.CMS/typo3/sysext/core/Classes/Database/Driver/PDOConnection.php on line 28 ERROR: 255
  5. Wouter Wolters voted on patch set 1 V +1 CR +1 12/24/21, 08:26

  6. Stefan Froemken commented on patch set 1 12/24/21, 13:23

    Review +1?!?! Please update your composer to at least version 2.2. allow-plugins is a new feature of composer 2.2. Of cause, if you're working with composer 2.1 it will work.
  7. Benni Mack commented on patch set 1 12/27/21, 19:59

    Reply

    did you run a git update before?
  8. Stefan Bürk commented on patch set 1 V +1 CR +1 12/30/21, 13:32

    Reply

    The error output is not related to the composer or plugin thing. I would bet you have outdated vendor packages, so like Benni asked, ensure you have the current 11.5. branch checked out and furthermore have run 'composer install' (Build/Scripts/runTests.sh -p 8.0 -s composerInstall).

    Reply

    +1 is correct. It works with composer version 2.2.2 (stable channel). Your branch was not uptodate regarding the errors, the base branch and/or installed composer packages. So ensure you have uptodate 11.5 branch checked out and composer install executed.
  9. Stefan Bürk rebased onto patch set 2 01/03/22, 14:49

  10. core-ci voted on patch set 2 V +1 01/03/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21564

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 01/03/22, 15:22

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 01/03/22, 15:42

  13. Christian Kuhn merged patch set 3 01/03/22, 15:42