Review 11.5 Merged

72785[BUGFIX] Resolve shortcuts in HMENU to access restricted pages

Benni Mack CR +2 V +2 Normal +120 −45 updated 12/23/21, 13:36

Commit message

There is a difference between

> typolink.linkAccessRestrictedPages = 1 (only a toggle)
and
> HMENU.showAccessRestrictedPages = [pageId]|NONE

HMENU.showAccessRestrictedPages behaves like
the global option "config.typolinkLinkAccessRestrictedPages"

Basically, if a page is access restricted, link
to a different {pageId}.

This change explains the behavior:
-- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/

"typolink.linkAccessRestrictedPages" in contrast
still links to the actual disallowed page, which
is also nice in case you have a 403 error page in place.

This change fixes the behaviour of HMENU to behave
EXACTLY like the global config.typolinkLinkAccessRestrictedPages,
previously HMENU did some magic PLUS it set
"typolink.linkAccessRestrictedPages"

With this change, shortcuts to access restricted pages
now get properly transformed and linked for menus.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 12/23/21, 13:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/23/21, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21429

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/23/21, 13:36

  4. Benni Mack merged patch set 2 12/23/21, 13:36