Review main Merged

72795[TASK] Migrate FormEngineLinkBrowserAdapter to TypeScript

Benjamin Franzke CR +2 V +2 Normal +125 −104 updated 12/23/21, 14:10

Commit message

A human-readable diff of the applied changes can be inspected on:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72795/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineLinkBrowserAdapter.ts

No functional change to keep the diff minimal and prepare behaviour
as-is.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 68

  1. Benjamin Franzke uploaded patch set 1 12/22/21, 17:40

  2. Benjamin Franzke uploaded patch set 2 12/22/21, 17:42

  3. core-ci voted on patch set 2 V +1 12/22/21, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21404

  4. core-ci voted on patch set 1 V -1 12/22/21, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21403

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/22/21, 20:23

  6. Jochen Roth voted on patch set 2 V +1 CR +1 12/23/21, 13:01

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/23/21, 14:10

  8. Benjamin Franzke merged patch set 3 12/23/21, 14:10