Review main Merged Breaking

72799[!!!][TASK] Change method signatures and remove deprecated functionality

Benni Mack CR +2 V +2 Normal +16 −50 updated 01/03/22, 13:29

Commit message

This change reduces the amount of @todos regarding
method changes related to strict typing or interface changes
for TYPO3 v12.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 811

  1. Benni Mack uploaded patch set 1 12/23/21, 12:37

  2. core-ci voted on patch set 1 V -1 12/23/21, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21422

  3. Benni Mack uploaded patch set 2 12/30/21, 15:42

  4. core-ci voted on patch set 2 V +1 12/30/21, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21524

  5. Stefan Bürk commented on patch set 2 12/30/21, 16:29

    DatabaseRecordList.php:2744

    Todo said to protect method, should this not be changed to protected then ?
  6. Benni Mack uploaded patch set 3 12/30/21, 16:33

  7. Stefan Bürk commented on patch set 3 V +1 CR +1 12/30/21, 16:50

    DatabaseRecordList.php:2744 Reply

    Done
  8. core-ci voted on patch set 3 V +1 12/30/21, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21526

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 01/03/22, 12:12

  10. Benni Mack voted on patch set 3 V +2 CR +2 01/03/22, 13:29

  11. Benni Mack merged patch set 4 01/03/22, 13:29