Review main Merged

72800[BUGFIX] Fix PHP 8 notices in workspaces preview

Benni Mack CR +2 V +2 Easy +7 −7 updated 12/23/21, 15:18

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1213

  1. Benni Mack uploaded patch set 1 12/23/21, 13:14

  2. Simon Gilli voted on patch set 1 CR +1 12/23/21, 13:15

  3. core-ci voted on patch set 1 V +1 12/23/21, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21428

  4. Simon Gilli voted on patch set 1 V +1 12/23/21, 13:37

  5. Oliver Klee commented on patch set 1 12/23/21, 14:26

    StagesService.php:108

    Shouldn't this be !empty($previousStage)?
  6. Benni Mack commented on patch set 1 12/23/21, 14:57

    StagesService.php:108 Reply

    $previousStage can be array or false
  7. Oliver Klee commented on patch set 1 12/23/21, 15:01

    StagesService.php:108 Reply

    Ack
  8. Oliver Klee wrote 12/23/21, 15:01

    Removed cc Oliver Klee.
  9. Oliver Klee voted on patch set 1 CR +1 12/23/21, 15:02

  10. Stefan Bürk voted on patch set 1 V +1 CR +1 12/23/21, 15:07

  11. Oli Bartsch voted on patch set 1 V +1 CR +1 12/23/21, 15:17

  12. Benni Mack voted on patch set 1 V +2 CR +2 12/23/21, 15:18

  13. Benni Mack merged patch set 2 12/23/21, 15:18