Review main Merged

72801[BUGFIX] Be consistent in HMENU.special = language

Benni Mack CR +2 V +2 Easy +10 −10 updated 12/23/21, 16:21

Commit message

Previously, HMENU.addQueryString, which is only
available for special=language, was applied
not within the typolink() functionality but before.

By sorting out the properties, HMENU with
special=language now properly uses typolinks
addQueryString.

Using the magic property _ADD_GETVARS to activate
this option addQueryString but also using
the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows
to fix special=language issues.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 12/23/21, 13:35

  2. Benni Mack updated the commit message in patch set 2 12/23/21, 13:38

  3. core-ci voted on patch set 1 V +1 12/23/21, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21430

  4. core-ci voted on patch set 2 V +1 12/23/21, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21431

  5. Benni Mack uploaded patch set 3 12/23/21, 14:56

  6. core-ci voted on patch set 3 V +1 12/23/21, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21432

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 12/23/21, 15:20

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 12/23/21, 15:52

  9. Benni Mack voted on patch set 3 V +2 CR +2 12/23/21, 16:21

  10. Benni Mack merged patch set 4 12/23/21, 16:21