Review main Merged

72802[BUGFIX] Check for excludeUidList in HMENU of default language

Benni Mack CR +2 V +2 Normal +76 −5 updated 01/06/22, 15:09

Commit message

This change now always checks for the actual page ID
in the default language, not of the translated page
to see if the page should be excluded.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Benni Mack uploaded patch set 1 12/23/21, 16:27

  2. core-ci voted on patch set 1 V -1 12/23/21, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21439

  3. Benni Mack uploaded patch set 2 12/28/21, 11:38

  4. core-ci voted on patch set 2 V +1 12/28/21, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21477

  5. Benni Mack uploaded patch set 3 12/30/21, 14:50

  6. core-ci voted on patch set 3 V +1 12/30/21, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21522

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 12/30/21, 15:00

  8. Oli Bartsch commented on patch set 3 V -1 01/03/22, 13:15

    The added tests currently pass even without the patch.
  9. Stefan Bürk commented on patch set 3 V 0 CR 0 01/03/22, 14:08

    Reply

    Will look into the tests later.
  10. Stefan Bürk uploaded patch set 4 01/03/22, 21:21

  11. core-ci voted on patch set 4 V +1 01/03/22, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21572

  12. Stefan Bürk commented on patch set 4 CR -1 01/03/22, 21:34

    Updated tests (after rebase). -1 still valid from Oliver, test green with and without change. Could not create testcase for this change, as uid is default language uid, even with parent. Maybe there were changes lately which work around this issue with before this change. Needs further investigation and talk with Benni. So re-apply -1 for now.
  13. Benni Mack commented on patch set 4 01/05/22, 11:28

    maybe this bug is already fixed?
  14. Benni Mack uploaded patch set 5 01/05/22, 12:50

  15. core-ci voted on patch set 5 V +1 01/05/22, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21643

  16. Oli Bartsch voted on patch set 5 V +1 CR +1 01/06/22, 14:57

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 01/06/22, 14:59

  18. Benni Mack voted on patch set 5 V +2 CR +2 01/06/22, 15:09

  19. Benni Mack merged patch set 6 01/06/22, 15:09