72803[FEATURE] Add content object related arguments to HtmlViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1927
Show 2 earlier messages
-
core-ci voted on patch set 2 V -1 12/23/21, 23:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21447
-
Stefan Froemken uploaded patch set 3 12/23/21, 23:26
-
core-ci voted on patch set 3 V -1 12/23/21, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21448
-
Stefan Froemken uploaded patch set 4 12/24/21, 00:34
-
core-ci voted on patch set 4 V +1 12/24/21, 00:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21449
-
Benni Mack commented on patch set 4 12/24/21, 11:50
-
Stefan Froemken commented on patch set 4 12/24/21, 12:51
Feature-92749-AddDataAttributeToHtmlViewHelper.rst:35ReplyI only have taken it from current main branch of TYPO3 11 :-) Seems to be a top modern solution to do so :D https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php#L42 -
Stefan Froemken uploaded patch set 5 12/24/21, 13:17
-
Stefan Froemken commented on patch set 5 12/24/21, 13:17
I have updated the examples a little bit to be more modern and "cool". Hope it's OK. -
core-ci voted on patch set 5 V +1 12/24/21, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21455
-
Oli Bartsch commented on patch set 5 01/03/22, 15:11
To me this is a bit misleading. There is no HTML "data" attribute added, but a new VH argument, called "data". Additionally, the "data" argument is not the only new argument. Could we please update this accordingly (also in the Feature.rst)? -
Stefan Froemken updated the commit message in patch set 6 01/05/22, 21:45
-
core-ci voted on patch set 6 V +1 01/05/22, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21668
-
Oli Bartsch commented on patch set 6 01/06/22, 13:19
HtmlViewHelper.php:69With the current implementation, this only works in case this is already an array. Usually such records can also be objects (e.g. defined via domain models and fetched by an extbase repository). -
Oli Bartsch uploaded patch set 7 01/06/22, 13:28
-
Oli Bartsch updated the commit message in patch set 8 01/06/22, 13:30
-
Oli Bartsch commented on patch set 8 V +1 CR +1 01/06/22, 13:31
Reply
DoneHtmlViewHelper.php:69ReplyDone -
core-ci voted on patch set 7 V +1 01/06/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21694
-
core-ci voted on patch set 8 V +1 01/06/22, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21695
-
Benni Mack commented on patch set 9 01/06/22, 14:27
Published edit on patch set 8. -
Benni Mack voted on patch set 9 V +1 CR +1 01/06/22, 14:28
-
Oli Bartsch voted on patch set 9 V +1 CR +1 01/06/22, 14:29
-
core-ci voted on patch set 9 V +1 01/06/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21705
-
Benni Mack commented on patch set 9 V +2 CR +2 01/06/22, 14:52
Thanks, Stefan for providing the patch! -
Benni Mack merged patch set 10 01/06/22, 14:52
Feature-92749-AddDataAttributeToHtmlViewHelper.rst:35