72804[BUGFIX] Provide quoted array to string-list implode support
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+68 −0
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+0 −62
- typo3/sysext/linkvalidator/Classes/QueryRestrictions/EditableRestriction.php+1 −1
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+9 −10
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+1 −2
Review log 1824
-
Stefan Bürk uploaded patch set 1 12/27/21, 16:41
-
Stefan Bürk updated the commit message in patch set 2 12/27/21, 16:46
-
core-ci voted on patch set 1 V +1 12/27/21, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21467
-
core-ci voted on patch set 2 V +1 12/27/21, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21468
-
Stefan Bürk marked it work in progress 12/28/21, 11:19
-
Stefan Bürk uploaded patch set 3 01/04/22, 10:07
-
core-ci voted on patch set 3 V +1 01/04/22, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21578
-
Christian Kuhn uploaded patch set 4 01/04/22, 12:04
-
core-ci voted on patch set 4 V +1 01/04/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21583
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/04/22, 12:54
-
Christian Kuhn commented on patch set 4 01/05/22, 11:42
-
Stefan Bürk commented on patch set 4 01/05/22, 11:44
Connection.php:222ReplySound's reasonable - but what about the companion above ? Write out quoteImplodeIntegerArray() too ? -
Stefan Bürk commented on patch set 4 01/05/22, 11:45
Connection.php:222ReplyAnd method(s) in QueryBuilder should be aligned too then, will push shortly new version. Thanks for pointing this out. -
Stefan Bürk commented on patch set 4 CR -1 01/05/22, 11:50
on it -
Stefan Bürk uploaded patch set 5 01/05/22, 11:52
-
core-ci voted on patch set 5 V +1 01/05/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21640
-
Stefan Bürk commented on patch set 5 CR -1 01/05/22, 12:37
Talked with lolli, will remove methods from connection.Connection.php:222ReplyDone. Did not changed the other, quoteImplodeIntArray() should be okay. -
Benni Mack commented on patch set 5 01/05/22, 12:58
Connection.php:188"quoteArrayBasedValueListToIntegerList" ?Connection.php:222"quoteArrayBasedValueListToStringList" ? -
Stefan Bürk uploaded patch set 6 01/05/22, 14:59
-
Christian Kuhn commented on patch set 6 01/05/22, 15:09
Connection.php:188ReplyDoneConnection.php:222ReplyDone -
core-ci voted on patch set 6 V +1 01/05/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21650
-
Benni Mack voted on patch set 6 V +1 CR +1 01/05/22, 15:43
-
Christian Kuhn voted on patch set 6 V +2 CR +2 01/05/22, 16:11
-
Christian Kuhn merged patch set 7 01/05/22, 16:21
Connection.php:222