Review main Merged

72804[BUGFIX] Provide quoted array to string-list implode support

Stefan Bürk CR +2 V +2 Normal +79 −75 updated 01/05/22, 16:21

Commit message

With #96393 forward-compatible prepared statement
suport has been added, which lacks support for the
broadly known doctrine/dbal 'PARAM_STR_ARRAY' and
'PARAM_INT_ARRAY' types.

Internal methods as alternatives were introduced
as core internal methods with #92493 in the internal
'QueryHelper' class.

This patch now moves these internal implementations
to the 'QueryBuilder' to provide an forward-compatible
public alternative, which is needed to prepare statements
with 'in()' or 'notIn()' expression with array values,
which can only be used as non-placeholder, which is not
supported by PHP PDO implementation.

Further usage of internal implementation which was
introduced with #92493 are replaced with new public
methods and internal methods in QueryHelper removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1824

  1. Stefan Bürk uploaded patch set 1 12/27/21, 16:41

  2. Stefan Bürk updated the commit message in patch set 2 12/27/21, 16:46

  3. core-ci voted on patch set 1 V +1 12/27/21, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21467

  4. core-ci voted on patch set 2 V +1 12/27/21, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21468

  5. Stefan Bürk marked it work in progress 12/28/21, 11:19

  6. Stefan Bürk uploaded patch set 3 01/04/22, 10:07

  7. core-ci voted on patch set 3 V +1 01/04/22, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21578

  8. Christian Kuhn uploaded patch set 4 01/04/22, 12:04

  9. core-ci voted on patch set 4 V +1 01/04/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21583

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 01/04/22, 12:54

  11. Christian Kuhn commented on patch set 4 01/05/22, 11:42

    Connection.php:222

    maybe quoteImplodeStringArray() ?
  12. Stefan Bürk commented on patch set 4 01/05/22, 11:44

    Connection.php:222 Reply

    Sound's reasonable - but what about the companion above ? Write out quoteImplodeIntegerArray() too ?
  13. Stefan Bürk commented on patch set 4 01/05/22, 11:45

    Connection.php:222 Reply

    And method(s) in QueryBuilder should be aligned too then, will push shortly new version. Thanks for pointing this out.
  14. Stefan Bürk commented on patch set 4 CR -1 01/05/22, 11:50

    on it
  15. Stefan Bürk uploaded patch set 5 01/05/22, 11:52

  16. core-ci voted on patch set 5 V +1 01/05/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21640

  17. Stefan Bürk commented on patch set 5 CR -1 01/05/22, 12:37

    Talked with lolli, will remove methods from connection.

    Connection.php:222 Reply

    Done. Did not changed the other, quoteImplodeIntArray() should be okay.
  18. Benni Mack commented on patch set 5 01/05/22, 12:58

    Connection.php:188

    "quoteArrayBasedValueListToIntegerList" ?

    Connection.php:222

    "quoteArrayBasedValueListToStringList" ?
  19. Stefan Bürk uploaded patch set 6 01/05/22, 14:59

  20. Christian Kuhn commented on patch set 6 01/05/22, 15:09

    Connection.php:188 Reply

    Done

    Connection.php:222 Reply

    Done
  21. core-ci voted on patch set 6 V +1 01/05/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21650

  22. Benni Mack voted on patch set 6 V +1 CR +1 01/05/22, 15:43

  23. Christian Kuhn voted on patch set 6 V +2 CR +2 01/05/22, 16:11

  24. Christian Kuhn merged patch set 7 01/05/22, 16:21