72806[TASK] Update to TypeScript 4.5
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 124
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Module/Iframe.ts+2 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Module/Router.ts+6 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ClipboardPanel.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ColumnSelectorButton.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineLinkBrowserAdapter.ts+2 −2
- Build/Sources/TypeScript/backend/Tests/IconsTest.ts+1 −1
- Build/Sources/TypeScript/viewpage/Resources/Public/TypeScript/Main.ts+1 −1
- Build/eslintrc.jsonrenamed+10 −10
- Build/Gruntfile.js+1 −1
- Build/package.json+6 −7
- Build/tsconfig.json+1 −0
- Build/yarn.lock+243 −233
- typo3/sysext/backend/Resources/Public/JavaScript/Element/IconElement.js+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Element/SpinnerElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Element/TableWizardElement.js+13 −13
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeToolbar.js+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/RequestUpdate.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/Paste.js+1 −1
Show 104 more files
- typo3/sysext/backend/Resources/Public/JavaScript/Module/Iframe.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Module/Router.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+8 −8
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ClearCacheMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/DragDrop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageBrowser.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/PageBrowser.js+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/ContentContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/ResizableNavigation.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/Toolbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ClipboardPanel.js+6 −6
- typo3/sysext/backend/Resources/Public/JavaScript/ColorPicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ColumnSelectorButton.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/CopyToClipboard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DebugConsole.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DocumentSaveActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineReview.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineSuggest.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LiveSearch.js+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Localization.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Login.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LoginRefresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Modal.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/MultiStepWizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/NewContentElementWizardButton.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/NewMultiplePages.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Notification.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Popover.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/SwitchUser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tabs.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/UserPassLogin.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Wizard.js+1 −1
- typo3/sysext/backend/Tests/JavaScript/PopoverTest.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Authentication/MfaProvider/Totp.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/DashboardModal.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetRefresh.js+1 −1
- typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetSelector.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Repository.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Update.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/UploadForm.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+1 −1
- typo3/sysext/impexp/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/impexp/Resources/Public/JavaScript/ImportExport.js+1 −1
- typo3/sysext/info/Resources/Public/JavaScript/TranslationStatus.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Environment/EnvironmentCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Environment/FolderStructure.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Environment/ImageProcessing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/ClearTables.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/ClearTypo3tempFiles.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/DatabaseAnalyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Maintenance/LanguagePacks.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/ExtensionConfiguration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/Features.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/LocalConfiguration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/Presets.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/SystemMaintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/CoreUpdate.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/ExtensionCompatTester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/ExtensionScanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/TcaExtTablesCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/TcaMigrationsCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeDocs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeWizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/AbstractInteractableModule.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/PasswordStrength.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Renderable/FlashMessage.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Renderable/InfoBox.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Renderable/ProgressBar.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Install.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Installer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Router.js+1 −1
- typo3/sysext/lowlevel/Resources/Public/JavaScript/QueryGenerator.js+1 −1
- typo3/sysext/opendocs/Resources/Public/JavaScript/Toolbar/OpendocsMenu.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/LinkBrowser.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/RecordDownloadButton.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
- typo3/sysext/recycler/Resources/Public/JavaScript/Recycler.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/FormEngineInitializer.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/RteLinkBrowser.js+1 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/Scheduler.js+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/Element/CodeMirrorElement.js+2 −2
- typo3/sysext/tstemplate/Resources/Public/JavaScript/ConstantEditor.js+1 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/Main.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Toolbar/WorkspacesMenu.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Preview.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Workspaces.js+1 −1
Review log 1318
-
Benjamin Franzke uploaded patch set 1 12/28/21, 09:05
-
Benjamin Franzke uploaded patch set 2 12/28/21, 09:16
-
core-ci voted on patch set 1 V +1 12/28/21, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21474
-
core-ci voted on patch set 2 V +1 12/28/21, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21475
-
Benjamin Franzke updated the commit message in patch set 3 12/28/21, 09:39
-
core-ci voted on patch set 3 V +1 12/28/21, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21476
-
Benni Mack voted on patch set 3 CR +1 12/28/21, 11:49
-
Benjamin Franzke commented on patch set 3 CR -1 12/28/21, 12:07
Need to check why this currently "works" without explicitly setting "useDefineForClassFields": false, in tsconfig.json reference: https://github.com/lit/lit/issues/1985 https://github.com/microsoft/TypeScript/issues/45584 -
Benjamin Franzke uploaded patch set 4 12/28/21, 12:32
-
Benjamin Franzke commented on patch set 4 12/28/21, 12:32
Reply
Ok, we were not affected due to target: ES2017 in tsconfig.json Anyway, added the flag as explicit configuration as per Lit documentation. -
core-ci voted on patch set 4 V +1 12/28/21, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21479
-
Benjamin Franzke uploaded patch set 5 12/28/21, 13:48
-
Benjamin Franzke commented on patch set 5 12/28/21, 13:48
oops, needed by @typescript-eslint/* as peerDependency. No errors, but warnings during yarn upgrade. Therefore now re-added. -
core-ci voted on patch set 5 V +1 12/28/21, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21480
-
Benni Mack voted on patch set 5 V +1 CR +1 12/29/21, 20:44
-
Andreas Kienast commented on patch set 5 CR -1 12/30/21, 11:57
on it -
Andreas Kienast voted on patch set 5 V +2 CR +2 12/30/21, 12:12
-
Andreas Kienast merged patch set 6 12/30/21, 12:12