72811[BUGFIX] Avoid undefined array key in LegacyLinkNotationConverter
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 811
-
Chris Müller uploaded patch set 1 12/29/21, 07:26
-
core-ci voted on patch set 1 V -1 12/29/21, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21487
-
Chris Müller uploaded patch set 2 12/29/21, 17:13
-
core-ci voted on patch set 2 V +1 12/29/21, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21497
-
Nikita Hovratov uploaded patch set 3 12/29/21, 19:47
-
Nikita Hovratov commented on patch set 3 12/29/21, 19:51
Hey Chris, I added a testcase and modified your patch a bit. You probably have upgraded your TYPO3 instance from an older version. Is my testcase correct? I just appended a comma to the link value. Not sure, how this got in there for you. Can you test it again? -
core-ci voted on patch set 3 V +1 12/29/21, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21503
-
Benni Mack voted on patch set 3 V +1 CR +1 12/30/21, 10:07
-
Stefan Bürk voted on patch set 3 V +1 CR +1 12/30/21, 13:01
-
Andreas Kienast voted on patch set 3 V +2 CR +2 12/30/21, 14:37
-
Andreas Kienast merged patch set 4 12/30/21, 14:37