Review main Merged

72812[BUGFIX] Avoid duplicate pages in pagetree when rootPid is mounted

Benjamin Franzke CR +2 V +2 Normal +137 −11 updated 12/30/21, 13:30

Commit message

With the changes in #95854, implicit rootPid dbmounts caused
duplicated pages in pagetree, because explicit page mounts have
been considered multiple times for the pid=0 tree:

 * First time because of their relationship to pid = 0
 * Second time because of their explicit mount
   (which was sorted into the pid = 0 tree)

This happened because #95854 optimized to only use one call
to the PageTree repository, which then had the side effect
of merging "multiple" pages into one tree, instead
of showing "two" separate trees.

The patch ensures that multiple page trees are used when
the rootPid (0) is included as a webmount.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 12/29/21, 09:47

  2. core-ci voted on patch set 1 V +1 12/29/21, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21488

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/30/21, 10:31

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 12/30/21, 13:00

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 12/30/21, 13:30

  6. Andreas Kienast merged patch set 2 12/30/21, 13:30