Review main Merged

72813[BUGFIX] Fix ordering of db mounts in page tree

Benjamin Franzke CR +2 V +2 Easy +44 −6 updated 01/04/22, 14:33

Commit message

With the changes in #95854, database mounts
are no longer sorted by the order they are defined in
the group/user settings, but undefined by the
order the database returns.

DB mounts aren't sorted against each other,
that means sorting values are not meaningful anyway,
and results in uncontrolable orderings.

Explicitly preserve the order using usort().
Also revert groupAndSortPages() to the state prior
to #95854, as the forcePid parameter would now be unused.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1316

  1. Benjamin Franzke uploaded patch set 1 12/29/21, 09:50

  2. core-ci voted on patch set 1 V +1 12/29/21, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21489

  3. Benni Mack voted on patch set 1 CR +1 12/29/21, 20:27

  4. Oli Bartsch uploaded patch set 2 01/03/22, 14:13

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 01/03/22, 14:13

  6. core-ci voted on patch set 2 V +1 01/03/22, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21562

  7. Nikita Hovratov commented on patch set 2 V +1 01/03/22, 14:49

    TreeController.php:551

    Can we use <=> here?
  8. Benjamin Franzke commented on patch set 2 01/03/22, 15:34

    TreeController.php:551 Reply

    Yep, would work. I actually didn't know about the spaceship operator.
  9. Benjamin Franzke uploaded patch set 3 01/03/22, 15:41

  10. Benjamin Franzke commented on patch set 3 01/03/22, 15:41

    TreeController.php:551 Reply

    Done
  11. core-ci voted on patch set 3 V +1 01/03/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21569

  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 01/03/22, 15:53

  13. Benni Mack voted on patch set 3 V +1 CR +1 01/04/22, 12:57

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 01/04/22, 13:50

  15. Benjamin Franzke voted on patch set 3 V +2 CR +2 01/04/22, 14:33

  16. Benjamin Franzke merged patch set 4 01/04/22, 14:33