Review main Merged

72818[TASK] Migrate sys_log to JSON instead of serialized data

Benni Mack CR +2 V +2 Normal +200 −7 updated 03/09/22, 20:48

Commit message

This change puts the sys_log.data as json_encoded values
into the database. On top, it provides a trait
to handle the conversion properly, which can then be removed
in TYPO3 v13 or v14, depending on the further usages.

The actual trait for migration was introduced in the
previous change https://review.typo3.org/c/Packages/TYPO3.CMS/+/73859/
where certain log messages were streamlined already.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2441

Show 816 earlier messages
  1. Benni Mack uploaded patch set 1 12/30/21, 16:25

  2. core-ci voted on patch set 1 V -1 12/30/21, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21525

  3. Benni Mack uploaded patch set 2 01/01/22, 21:56

  4. core-ci voted on patch set 2 V -1 01/01/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21541

  5. Benni Mack uploaded patch set 3 01/01/22, 22:11

  6. core-ci voted on patch set 3 V +1 01/01/22, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21542

  7. Benni Mack uploaded patch set 4 03/08/22, 09:51

  8. core-ci voted on patch set 4 V -1 03/08/22, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24708

  9. Benni Mack uploaded patch set 5 03/08/22, 10:46

  10. core-ci voted on patch set 5 V -1 03/08/22, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24710

  11. Benni Mack uploaded patch set 6 03/08/22, 11:16

  12. core-ci voted on patch set 6 V +1 03/08/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24711

  13. Benni Mack uploaded patch set 7 03/08/22, 15:29

  14. core-ci voted on patch set 7 V +1 03/08/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24715

  15. Benni Mack uploaded patch set 8 03/08/22, 15:59

  16. core-ci voted on patch set 8 V -1 03/08/22, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24716

  1. Benni Mack uploaded patch set 9 03/08/22, 16:16

  2. core-ci voted on patch set 9 V +1 03/08/22, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24718

  3. Benni Mack rebased onto patch set 10 03/08/22, 16:31

  4. core-ci voted on patch set 10 V +1 03/08/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24719

  5. Benni Mack uploaded patch set 11 03/09/22, 06:33

  6. core-ci voted on patch set 11 V -1 03/09/22, 06:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24727

  7. Benni Mack rebased onto patch set 12 03/09/22, 11:33

  8. core-ci voted on patch set 12 V +1 03/09/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24741

  9. Benni Mack commented on patch set 13 03/09/22, 12:46

    Published edit on patch set 12.
  10. core-ci voted on patch set 13 V +1 03/09/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24747

  11. Oli Bartsch uploaded patch set 14 03/09/22, 13:06

  12. Oli Bartsch voted on patch set 14 V +1 CR +1 03/09/22, 13:06

  13. core-ci voted on patch set 14 V +1 03/09/22, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24748

  14. Benni Mack commented on patch set 15 03/09/22, 14:43

    Published edit on patch set 14.
  15. core-ci voted on patch set 15 V +1 03/09/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24752

  16. Benni Mack uploaded patch set 16 03/09/22, 17:45

  17. core-ci voted on patch set 16 V +1 03/09/22, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24761

  18. Stefan Bürk commented on patch set 16 03/09/22, 18:02

    BackendUserAuthentication.php:2045

    should we not use 'empty()' here like other places ? Can it be dat $data is not an array at all - or can we really take that as safe assumption ?
  19. Benni Mack commented on patch set 17 03/09/22, 19:06

    Published edit on patch set 16.
  20. Benni Mack commented on patch set 17 03/09/22, 19:06

    BackendUserAuthentication.php:2045 Reply

    in this case, array can be something else as far as I can see. but we can strong-type here...
  21. core-ci voted on patch set 17 V +1 03/09/22, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24764

  22. Oli Bartsch voted on patch set 17 V +1 CR +1 03/09/22, 20:15

  23. Jochen Roth voted on patch set 17 V +1 CR +1 03/09/22, 20:21

  24. Benni Mack voted on patch set 17 V +2 CR +2 03/09/22, 20:48

  25. Benni Mack merged patch set 18 03/09/22, 20:48