Review main Merged

72820[BUGFIX] Add TCA migration for select authMode keywords

Nikita Hovratov CR +2 V +2 Hard +340 −5 updated 01/04/22, 15:57

Commit message

With the introduction of itemGroups, the index 3 of
the select items array has been shifted one position
to the right. Before that, the index 3 was used for
descriptions and index 4 for an optional keyword
EXPL_ALLOW or EXPL_DENY. These are used together
with authMode=individual to explicitly allow or deny
single items.

Since descriptions now occupy the index 4, the
former usage of this index needs to be shifted as
well to index 5.

For backwards compatibility reasons, a TCA migration
is added, which will check for these special
keywords and move them one index up.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1418

  1. Nikita Hovratov uploaded patch set 1 12/31/21, 17:10

  2. core-ci voted on patch set 1 V +1 12/31/21, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21533

  3. Oli Bartsch commented on patch set 1 01/03/22, 12:15

    TcaMigration.php:576

    Should we use the actual value ($item[4]) here?
  4. Nikita Hovratov uploaded patch set 2 01/03/22, 14:35

  5. Nikita Hovratov commented on patch set 2 01/03/22, 14:36

    TcaMigration.php:576 Reply

    Done
  6. core-ci voted on patch set 2 V +1 01/03/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21563

  7. Oli Bartsch uploaded patch set 3 01/04/22, 13:49

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 01/04/22, 13:50

  9. Nikita Hovratov commented on patch set 3 01/04/22, 13:53

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:32

    authMode
  10. Christian Kuhn commented on patch set 3 01/04/22, 13:57

    ... we really should resolve this stupid numbered item array in v12 and give it properly named keys ...
  11. Nikita Hovratov commented on patch set 3 01/04/22, 14:04

    Reply

    YES
  12. Oli Bartsch commented on patch set 4 01/04/22, 14:05

    Published edit on patch set 3.
  13. Oli Bartsch commented on patch set 4 V +1 CR +1 01/04/22, 14:05

    Deprecation-96444-AuthModeSelectItemsKeywordsMovedToIndex5.rst:32 Reply

    Done
  14. core-ci voted on patch set 3 V +1 01/04/22, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21588

  15. core-ci voted on patch set 4 V +1 01/04/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21589

  16. Christian Kuhn voted on patch set 4 V +1 CR +1 01/04/22, 15:51

  17. Oli Bartsch voted on patch set 4 V +2 CR +2 01/04/22, 15:57

  18. Oli Bartsch merged patch set 5 01/04/22, 15:57