Review main Merged

72821[TASK] Extract symmetric mn scenario from ext:irre_tutorial

Anja Leichsenring CR +2 V +2 Expert +592 −546 updated 01/04/22, 16:47

Commit message

The scenario provided by tables tx_irretutorial_mn_sym_* gets
its own test extension and gets loaded where needed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 811

  1. Anja Leichsenring uploaded patch set 1 01/01/22, 09:35

  2. core-ci voted on patch set 1 V +1 01/01/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21537

  3. Christian Kuhn commented on patch set 1 01/04/22, 14:18

    See my comment on https://forge.typo3.org/issues/95949 - i think we should name the new extension test_irre_mnsymmetric
  4. Christian Kuhn commented on patch set 1 CR -1 01/04/22, 14:18

    on it.
  5. Christian Kuhn uploaded patch set 2 01/04/22, 14:44

  6. Christian Kuhn uploaded patch set 3 01/04/22, 14:50

  7. core-ci voted on patch set 2 V +1 01/04/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21597

  8. core-ci voted on patch set 3 V +1 01/04/22, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21599

  9. Stefan Bürk commented on patch set 3 V +1 CR +1 01/04/22, 15:52

    Thanks for the patch Anja, and thx Christian for the renaming.
  10. Christian Kuhn voted on patch set 3 V +2 CR +2 01/04/22, 16:47

  11. Christian Kuhn merged patch set 4 01/04/22, 16:47