Review main Abandoned

72822[TASK] Add dependencies for EXT:extensionmanager

Sybille Peters CR 0 V 0 Easy +9 −1 updated 01/02/22, 10:06

Commit message

Add dependencies for EXT:extensionmanager in composer.json

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1417

  1. Sybille Peters uploaded patch set 1 01/01/22, 09:49

  2. core-ci voted on patch set 1 V +1 01/01/22, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21538

  3. Chris Müller commented on patch set 1 01/01/22, 13:59

    Why impexp, scheduler and reports as a hard requirement? For example, I don't have impexp installed in my systems, EM works correctly for me(TM) without it. scheduler and reports look for me more like a suggestion than a requirement. Probably also impexp.
  4. Simon Gilli commented on patch set 1 CR -1 01/01/22, 14:15

    Like already mentioned by Chris some optional dependencies are added here which is not what we want. They can be added in the suggest section instead.
  5. Chris Müller commented on patch set 1 CR -1 01/01/22, 14:17

    Okay, digged into it: for scheduler and reports hooks are registered. If they are not installed, have no update task in scheduler and no reports for extension statuses. Impexp is used mainly in the InstallUtility to import t3d's from Initialisation folder. The other usages check, if the extension is installed. Would see all three as suggests.
  6. Chris Müller uploaded patch set 2 01/01/22, 14:20

  7. Chris Müller commented on patch set 2 01/01/22, 14:21

    Added impexp, scheduler, reports to suggest section.
  8. Chris Müller uploaded patch set 3 01/01/22, 14:22

  9. core-ci voted on patch set 2 V +1 01/01/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21539

  10. core-ci voted on patch set 3 V +1 01/01/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21540

  11. Oliver Klee voted on patch set 3 CR +1 01/01/22, 14:44

  12. Sybille Peters commented on patch set 3 01/01/22, 14:46

    Reply

    You are right. Makes more sense that way. Thanks for taking care of it.
  13. Benni Mack commented on patch set 3 01/01/22, 18:47

    As this topic came up multiple times in the past years already: What's the benefit of this change?
  14. Oliver Klee commented on patch set 3 01/01/22, 18:55

    Reply

    This change ensures that in Composer-based distributions/sites, all extension are installed that are required for the explicitly required extensions (in this case, the EM) to work.
  15. Benni Mack commented on patch set 3 01/01/22, 19:56

    Reply

    I do see your point however I see the following problems with this approach: -- a) We only analyze PHP classes. A link to a different module / route or "isLoaded("workspaces")" is not considered. We also ship Fluid modules -- b) We do not see the indirect dependencies (in the end, every module uses TypoScript, based on Extbase, which then needs TSFE and cObj which then needs EXT:frontend). This basically will lead to a cross-dependency / circular dependencies, which we should rather resolve and come up with a good concept to between -- c) This change adapts the dependencies manually, so whenever a dependency is not needed anymore, we can't track that we need / could remove dependencies again once the code changes. These issues were one of the reason when we initially built the system extensions with a sole dependency to typo3/cms-core back in v6 / v8. Personally, I'm in much favor of only having dependencies to core, frontend and backend and that's it (for system extensions). For this to happen we should rather come up with a concept on how to decouple functionality further. E.g. you might have seen that I'm constructing a ViewInterface (separate patch) to not rely on EXT:fluid for all the code anymore, or even EXT:extbase, if this is not needed in a system extension, and make sure we have a framework based on components. I'm not against such changes (also told this to Simon back then), but these are just my 2 cents why I personally see that this might very time consuming (for me, also to maintain) which I could rather be spending on decoupling.
  16. Sybille Peters commented on patch set 3 01/02/22, 10:05

    I was not aware this would be such a big problem. I noticed that extensionmanager was using extbase and was not sure what other dependencies it had. I thought it might be difficult for administrators to figure out which system extensions they NEED and which are optional. Also other system extensions do list dependencies, such as adminpanel, dashboard. But if this is very time-consuming now and better done at a later time, will abandon.
  17. Sybille Peters abandoned the change 01/02/22, 10:06

    Should rather focus on decoupling functionality further, too many implicit dependencies, see comments