72825[BUGFIX] Do not overwrite previously set preview mode
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1822
-
Susi Moog uploaded patch set 1 01/02/22, 11:03
-
Susi Moog commented on patch set 1 01/02/22, 11:04
Note: on PHP 8.1 (and maybe 8) you'll need https://review.typo3.org/c/Packages/TYPO3.CMS/+/72824 previously to test this. -
core-ci voted on patch set 1 V -1 01/02/22, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21548
-
Susi Moog uploaded patch set 2 01/02/22, 12:26
-
core-ci voted on patch set 2 V +1 01/02/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21550
-
Rémy DANIEL commented on patch set 2 CR -1 01/02/22, 13:25
PreviewModule.php:172This line should be removed, because the aspect is now properly defined at the end of the method. Also, this line will cause the `if` line 213 to always pass. -
Susi Moog commented on patch set 2 01/03/22, 05:57
PreviewModule.php:172Replytrue - a bit too much streamlining here ;) Will fix it, thanks! -
Susi Moog uploaded patch set 3 01/03/22, 06:00
-
core-ci voted on patch set 3 V +1 01/03/22, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21556
-
Susi Moog commented on patch set 3 01/03/22, 09:09
PreviewModule.php:172ReplyDone -
Rémy DANIEL voted on patch set 3 CR +1 01/03/22, 18:36
-
Christian Kuhn voted on patch set 3 V +1 CR +1 01/04/22, 13:15
-
Benni Mack commented on patch set 3 CR -1 01/04/22, 13:19
PreviewSimulator.php:64why is this cast to int() in the first place? shouldn't this be a bool() ? -
Christian Kuhn commented on patch set 3 V 0 CR 0 01/04/22, 13:20
PreviewSimulator.php:64ReplyAck -
Susi Moog commented on patch set 3 01/04/22, 13:21
PreviewSimulator.php:64Replyfun for everyone, yes, that has been wrong before, is wrong now and should be fixed in both places. I can take care later if no-one else is faster. -
Christian Kuhn uploaded patch set 4 01/04/22, 13:48
-
Christian Kuhn commented on patch set 4 V +1 CR +1 01/04/22, 13:48
PreviewSimulator.php:64ReplyDone -
Benni Mack voted on patch set 4 V +1 CR +1 01/04/22, 13:59
-
Susi Moog commented on patch set 4 01/04/22, 14:02
PreviewSimulator.php:64ReplyThank you! -
core-ci voted on patch set 4 V +1 01/04/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21587
-
Christian Kuhn commented on patch set 4 V +2 CR +2 01/04/22, 14:21
PreviewSimulator.php:64ReplyWelcome! -
Christian Kuhn merged patch set 5 01/04/22, 14:22