72826[TASK] Make status of simulate time clearer
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Sybille Peters +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/adminpanel.scss+4 −0
- Build/Sources/TypeScript/adminpanel/Resources/Public/TypeScript/Modules/Preview.ts+19 −0
- typo3/sysext/adminpanel/Resources/Private/Partials/Form/DateTime.html+7 −4
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/adminpanel/Resources/Public/JavaScript/Modules/Preview.js+1 −1
Review log 1315
-
Susi Moog uploaded patch set 1 01/02/22, 12:13
-
core-ci voted on patch set 1 V +1 01/02/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21549
-
Chris Müller voted on patch set 1 V +1 CR +1 01/02/22, 16:13
-
Sybille Peters commented on patch set 1 01/03/22, 09:05
Before testing this, can we merge https://review.typo3.org/c/Packages/TYPO3.CMS/+/72824? Otherwise, can't test this with PHP 8, at last on my system there is an exception (not just with PHP 8.1 but PHP 8.0 too). -
Susi Moog commented on patch set 1 01/03/22, 14:59
Reply
Benni merged the other one, this one should now be testable without pre-requisites. -
Stefan Bürk rebased onto patch set 2 01/04/22, 10:36
-
Stefan Bürk voted on patch set 2 V +1 CR +1 01/04/22, 10:36
-
core-ci voted on patch set 2 V +1 01/04/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21579
-
Sybille Peters commented on patch set 2 01/04/22, 11:32
Shouldn't this be a feature? I am not insisting on it, it is just that usually with UI changes we declare it as a feature and have a changelog (which would also describe the feature). I do realize you could not backport to v11 in this case but I think that is ok. -
Sybille Peters commented on patch set 2 01/04/22, 11:34
I definitely like the checkbox but wondering if a checkbox should not be available for the usergroup as well for consistency. For the usergroup it is not necessary because you could set it to blank. But having a checkbox for both would a) be more consistent and b) have advantage that previous usergroup setting is still saved but can be temporarily disabled. Again, this is my opinion, not a real blocking and thus not reviewing with -1. Have not tested funcionality yet. -
Sybille Peters voted on patch set 2 V +1 01/04/22, 13:50
-
Christian Kuhn commented on patch set 2 V +1 CR +1 01/04/22, 13:56
Reply
I think we can live without the checkbox for the group drop-down - setting the box empty should be straight enough I suppose.Reply
Mmmh, imho that's a relatively straight usability improvement - people will stumble upon that upon use, imho fine to make it neither a feature, nor have it a .rst file. -
Susi Moog commented on patch set 2 01/05/22, 10:32
Reply
I even thought about making it a usability bugfix because it's really hard (next to impossible ;)) to grasp how to reset the settings without this change, however, I don't consider this "feature-worthy" as it's not really something new, just an existing functionality being more usable. -
Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/22, 13:45
-
Christian Kuhn merged patch set 3 01/05/22, 13:45