Review main Merged

72828[BUGFIX] Use realpath() for vcsIgnore in CGL fixer

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/03/22, 15:27

Commit message

It seems that symfony >= 5.4.0 has a bug in symfony
finder that .gitignore files are no longer always
found when the ->in() directive is a non-absolute
path with '/../'.
This triggers issues with our cgl fixer script in
nightly mode.
We work around that by using an absolute path
instead in the configuration and will report the
issue to symfony.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Christian Kuhn uploaded patch set 1 01/03/22, 14:49

  2. core-ci voted on patch set 1 V +1 01/03/22, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21565

  3. core-ci commented on patch set 1 01/03/22, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21566

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 01/03/22, 15:26

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/03/22, 15:27

  6. Christian Kuhn merged patch set 2 01/03/22, 15:27