Review main Merged

72830[BUGFIX] Check correctly for TCA search options

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 01/04/22, 11:50

Commit message

The documentation states "case" and "pidonly" are
of type boolean. But in the code in_array was used
to decide, whether to utilize these options.

This is now fixed by checking for the array keys.

Some lines above in the first if-branch, this has
been already fixed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Nikita Hovratov uploaded patch set 1 01/04/22, 08:26

  2. core-ci voted on patch set 1 V +1 01/04/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21577

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/04/22, 10:11

  4. Oli Bartsch voted on patch set 1 CR +1 01/04/22, 10:54

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/04/22, 11:02

  6. Christian Kuhn updated the commit message in patch set 2 01/04/22, 11:36

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/04/22, 11:37

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 01/04/22, 11:38

  9. core-ci voted on patch set 2 V +1 01/04/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21581

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 01/04/22, 11:49

  11. Christian Kuhn merged patch set 3 01/04/22, 11:50