Review 11.5 Merged

72838[BUGFIX] Avoid type errors in TimeTracker

Benni Mack CR +2 V +2 Easy +7 −4 updated 01/03/22, 11:17

Commit message

Make sure to pass strings to html formatting methods.
Initialize hierarchy array correctly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 01/03/22, 10:00

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/TimeTracker/TimeTracker.php
  2. core-ci voted on patch set 1 V -1 01/03/22, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21557

  3. Benni Mack commented on patch set 2 01/03/22, 10:22

    Published edit on patch set 1.
  4. Benni Mack marked it ready for review 01/03/22, 10:22

  5. core-ci voted on patch set 2 V +1 01/03/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21558

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/03/22, 11:17

  7. Benni Mack merged patch set 3 01/03/22, 11:17