Review main Merged

72853[TASK] Remove unneeded TypeScript module path configuration

Benjamin Franzke CR +2 V +2 Easy +6 −40 updated 01/05/22, 09:05

Commit message

Simplify tsconfig.json by removing unneded lookup configurations for
typo3/sysext/*/Resources/Public/JavaScript/ folders, as actually
no files are included from there.

The configuration originates back from #81416 where TypeScript
sources have been stored in typo3/sysext/. It is no longer needed,
now that all Sources are located in Build/Sources/TypeScript.

As a slight bonus, tsconfig.json will now automatically be updated
if a new extension is added in Build/Sources/TypeScript (previously
a JavaScript folder in typo3/sysext/ had to be added beforehand).

Executed commands:

  # executed to regenerate tsconfig.json
  grunt tsconfig
  # produces no changes, since config is equal to prior state
  grunt build

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Benjamin Franzke uploaded patch set 1 01/04/22, 14:26

  2. Benjamin Franzke updated the commit message in patch set 2 01/04/22, 14:29

  3. core-ci voted on patch set 1 V +1 01/04/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21591

  4. core-ci voted on patch set 2 V +1 01/04/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21593

  5. Benni Mack voted on patch set 2 CR +1 01/04/22, 19:58

  6. Benni Mack voted on patch set 2 V +1 01/05/22, 08:45

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 01/05/22, 09:05

  8. Oli Bartsch merged patch set 3 01/05/22, 09:05