Review 10.4 Merged

72854[BUGFIX] Fix ordering of db mounts in page tree

Benjamin Franzke CR +2 V +2 Easy +44 −6 updated 01/04/22, 15:14

Commit message

With the changes in #95854, database mounts
are no longer sorted by the order they are defined in
the group/user settings, but undefined by the
order the database returns.

DB mounts aren't sorted against each other,
that means sorting values are not meaningful anyway,
and results in uncontrolable orderings.

Explicitly preserve the order using usort().
Also revert groupAndSortPages() to the state prior
to #95854, as the forcePid parameter would now be unused.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 58

  1. Benjamin Franzke uploaded patch set 1 01/04/22, 14:33

  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/04/22, 14:34

  3. core-ci voted on patch set 1 V -1 01/04/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21595

  4. Benjamin Franzke uploaded patch set 2 01/04/22, 14:47

  5. core-ci voted on patch set 2 V -1 01/04/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21598

  6. Benjamin Franzke uploaded patch set 3 01/04/22, 14:58

  7. core-ci voted on patch set 3 V +1 01/04/22, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21600

  8. Benjamin Franzke merged patch set 4 01/04/22, 15:14