Review main Merged

72855[BUGFIX] Rename variable for storing the translated options

Jan Helke CR +2 V +2 Easy +1 −1 updated 01/04/22, 17:04

Commit message

Ensure that in a foreign language context the selected option will
be translated in the finishers. Regression fix introduced with #93979.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Marc Willmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Marc Willmann +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Jan Helke uploaded patch set 1 01/04/22, 14:59

  2. core-ci voted on patch set 1 V -1 01/04/22, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21601

  3. Christian Kuhn updated the commit message in patch set 2 01/04/22, 15:21

  4. Jan Helke uploaded patch set 3 01/04/22, 15:30

  5. core-ci voted on patch set 2 V -1 01/04/22, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21602

  6. Christian Kuhn voted on patch set 3 CR +1 01/04/22, 15:41

  7. core-ci voted on patch set 3 V +1 01/04/22, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21604

  8. Marc Willmann voted on patch set 3 V +1 CR +1 01/04/22, 16:33

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 01/04/22, 17:04

  10. Christian Kuhn merged patch set 4 01/04/22, 17:04