Review main Merged

72858[BUGFIX] Add CompositeExpression argument docblock type-hint

Ingo Fabbri CR +2 V +2 Easy +6 −6 updated 01/05/22, 08:43

Commit message

This patch adds missing 'CompositeExpression' as union
type for QueryBuilder methods 'where()', 'andWhere()'
and 'orWhere()' to match the ability of the underlaying
doctrine/dbal QueryBuilder methods.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Ingo Fabbri uploaded patch set 1 01/04/22, 16:35

  2. Ingo Fabbri updated the commit message in patch set 2 01/04/22, 16:37

  3. core-ci voted on patch set 1 V +1 01/04/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21609

  4. core-ci voted on patch set 2 V +1 01/04/22, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21610

  5. Stefan Bürk updated the commit message in patch set 3 01/04/22, 20:21

  6. Stefan Bürk rebased onto patch set 4 01/04/22, 20:27

  7. Stefan Bürk commented on patch set 4 V +1 CR +1 01/04/22, 20:30

    Adjusted commit message and solved weired relation-chain. Seems there went something wrong, which was solved with rebase. Tested and verified.
  8. core-ci voted on patch set 3 V +1 01/04/22, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21618

  9. core-ci voted on patch set 4 V +1 01/04/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21619

  10. Benni Mack voted on patch set 4 V +2 CR +2 01/05/22, 08:43

  11. Benni Mack merged patch set 5 01/05/22, 08:43