72860[BUGFIX] Mark shortcut pages as active in HMENU
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+56 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php3+50 −17
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+3 −27
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+80 −0
Review log 1319
-
Benni Mack uploaded patch set 1 01/04/22, 21:20
-
core-ci voted on patch set 1 V +1 01/04/22, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21620
-
Benni Mack uploaded patch set 2 01/05/22, 09:16
-
core-ci voted on patch set 2 V -1 01/05/22, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21630
-
Benni Mack uploaded patch set 3 01/05/22, 10:10
-
core-ci voted on patch set 3 V +1 01/05/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21632
-
Benni Mack updated the commit message in patch set 4 01/05/22, 10:20
-
Benni Mack commented on patch set 5 01/05/22, 10:24
Published edit on patch set 4. -
core-ci voted on patch set 4 V +1 01/05/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21633
-
core-ci voted on patch set 5 V +1 01/05/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21634
-
Stefan Bürk voted on patch set 5 CR +1 01/05/22, 11:20
-
Benni Mack commented on patch set 5 01/05/22, 11:27
AbstractMenuContentObject.php:906seems like an unrelated change... -
Benni Mack commented on patch set 6 01/05/22, 11:30
Published edit on patch set 5. -
Benni Mack commented on patch set 6 01/05/22, 11:35
AbstractMenuContentObject.php:906ReplyDone -
Stefan Bürk commented on patch set 6 V +1 CR +1 01/05/22, 11:39
AbstractMenuContentObject.php:906ReplyWas a nice breakpoint possibility in the future - but right, unrelated. -
core-ci voted on patch set 6 V +1 01/05/22, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21638
-
Oli Bartsch voted on patch set 6 V +1 CR +1 01/05/22, 12:25
-
Benni Mack voted on patch set 6 V +2 CR +2 01/05/22, 12:25
-
Benni Mack merged patch set 7 01/05/22, 12:25