Review main Merged

72860[BUGFIX] Mark shortcut pages as active in HMENU

Benni Mack CR +2 V +2 Normal +191 −46 updated 01/05/22, 12:25

Commit message

This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1319

  1. Benni Mack uploaded patch set 1 01/04/22, 21:20

  2. core-ci voted on patch set 1 V +1 01/04/22, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21620

  3. Benni Mack uploaded patch set 2 01/05/22, 09:16

  4. core-ci voted on patch set 2 V -1 01/05/22, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21630

  5. Benni Mack uploaded patch set 3 01/05/22, 10:10

  6. core-ci voted on patch set 3 V +1 01/05/22, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21632

  7. Benni Mack updated the commit message in patch set 4 01/05/22, 10:20

  8. Benni Mack commented on patch set 5 01/05/22, 10:24

    Published edit on patch set 4.
  9. core-ci voted on patch set 4 V +1 01/05/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21633

  10. core-ci voted on patch set 5 V +1 01/05/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21634

  11. Stefan Bürk voted on patch set 5 CR +1 01/05/22, 11:20

  12. Benni Mack commented on patch set 5 01/05/22, 11:27

    AbstractMenuContentObject.php:906

    seems like an unrelated change...
  13. Benni Mack commented on patch set 6 01/05/22, 11:30

    Published edit on patch set 5.
  14. Benni Mack commented on patch set 6 01/05/22, 11:35

    AbstractMenuContentObject.php:906 Reply

    Done
  15. Stefan Bürk commented on patch set 6 V +1 CR +1 01/05/22, 11:39

    AbstractMenuContentObject.php:906 Reply

    Was a nice breakpoint possibility in the future - but right, unrelated.
  16. core-ci voted on patch set 6 V +1 01/05/22, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21638

  17. Oli Bartsch voted on patch set 6 V +1 CR +1 01/05/22, 12:25

  18. Benni Mack voted on patch set 6 V +2 CR +2 01/05/22, 12:25

  19. Benni Mack merged patch set 7 01/05/22, 12:25