Review main Merged

72862[TASK] Adjust QueryBuilder PHPDoc comments

Ingo Fabbri CR +2 V +2 Easy +6 −6 updated 01/05/22, 13:44

Commit message

Some methods have the wrong type declaration.
E.g. string instead of mixed.
Add type-hints for completeness.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Ingo Fabbri uploaded patch set 1 01/05/22, 10:25

  2. core-ci voted on patch set 1 V +1 01/05/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21635

  3. Christian Kuhn updated the commit message in patch set 2 01/05/22, 12:27

  4. Christian Kuhn commented on patch set 2 01/05/22, 12:28

    Went through it, looks good. Just removed v10 as 'non-critical-fix'.
  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/05/22, 12:29

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 01/05/22, 12:35

  7. core-ci voted on patch set 2 V +1 01/05/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21642

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/22, 13:44

  9. Christian Kuhn merged patch set 3 01/05/22, 13:44