Review main Abandoned

72865[TASK] Remove treeConfig.rootUid TCA migration

Nikita Hovratov CR 0 V 0 Normal +0 −143 updated 01/06/22, 08:23

Commit message

The breaking change was already merged, but the
migration was forgotten.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 67

  1. Nikita Hovratov uploaded patch set 1 01/05/22, 16:55

  2. core-ci voted on patch set 1 V +1 01/05/22, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21660

  3. Oli Bartsch commented on patch set 1 01/05/22, 20:48

    Like for the other migrations, I left it there on purpose. Why do you want to remove this particular migration?
  4. Nikita Hovratov commented on patch set 1 01/05/22, 20:57

    Reply

    I thought they can be removed, when the breaking change is announced. Don't know how long these migrations should be kept. I don't mind keeping it one version longer, if you want. Weren't those added to these compatibility extensions before?
  5. Benni Mack commented on patch set 1 01/05/22, 21:32

    Reply

    I usually consider keeping them around for a looong time :) I mean, people upgrade from v10 => v12 and should also have that (upgrading two versions is recommended by a lot of people from the community).
  6. Nikita Hovratov commented on patch set 1 01/06/22, 08:22

    Reply

    Ok, understood :)
  7. Nikita Hovratov abandoned the change 01/06/22, 08:23

    Keep it for a longer period