Review main Merged

72866[BUGFIX] Use "pages.target" properly for Pages with External URL

Benni Mack CR +2 V +2 Normal +43 −24 updated 01/05/22, 22:41

Commit message

The database field "pages.target" allows to define
a custom target attribute for links in menus of external
URLs.

Before this was (wrongly) built in HMENU but applied
after Typolink worked. This option belongs to the
actual link building when building links to external URLs
where $conf[extTarget] is evaluated.

In addition, HMENU tests now also evaluate "target"
for regular pages as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Benni Mack uploaded patch set 1 01/05/22, 21:01

  2. Benni Mack uploaded patch set 2 01/05/22, 21:03

  3. core-ci voted on patch set 2 V +1 01/05/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21665

  4. core-ci voted on patch set 1 V +1 01/05/22, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21664

  5. Benni Mack updated the commit message in patch set 3 01/05/22, 21:33

  6. core-ci voted on patch set 3 V +1 01/05/22, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21666

  7. Stefan Bürk voted on patch set 3 CR +1 01/05/22, 21:58

  8. Stefan Bürk voted on patch set 3 V +1 01/05/22, 22:12

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 01/05/22, 22:40

  10. Benni Mack voted on patch set 3 V +2 CR +2 01/05/22, 22:41

  11. Benni Mack merged patch set 4 01/05/22, 22:41