72866[BUGFIX] Use "pages.target" properly for Pages with External URL
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+2 −13
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+4 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+33 −10
Review log 811
-
Benni Mack uploaded patch set 1 01/05/22, 21:01
-
Benni Mack uploaded patch set 2 01/05/22, 21:03
-
core-ci voted on patch set 2 V +1 01/05/22, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21665
-
core-ci voted on patch set 1 V +1 01/05/22, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21664
-
Benni Mack updated the commit message in patch set 3 01/05/22, 21:33
-
core-ci voted on patch set 3 V +1 01/05/22, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21666
-
Stefan Bürk voted on patch set 3 CR +1 01/05/22, 21:58
-
Stefan Bürk voted on patch set 3 V +1 01/05/22, 22:12
-
Oli Bartsch voted on patch set 3 V +1 CR +1 01/05/22, 22:40
-
Benni Mack voted on patch set 3 V +2 CR +2 01/05/22, 22:41
-
Benni Mack merged patch set 4 01/05/22, 22:41