Review main Merged

72868[TASK] Ensure that hidden pages are not rendered as subpages in HMENU

Benni Mack CR +2 V +2 Normal +72 −0 updated 01/05/22, 22:45

Commit message

This change adds tests to a very old issue to ensure
that a page with only hidden subpages is not marked
as IFSUB etc.

MenuProcessor is extended to set a "hasSubpages" flag
when IFSUB, CURIFSUB or ACTIFSUB is set.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Benni Mack uploaded patch set 1 01/05/22, 22:03

  2. Benni Mack updated the commit message in patch set 2 01/05/22, 22:04

  3. core-ci voted on patch set 1 V +1 01/05/22, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21669

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 01/05/22, 22:20

  5. core-ci voted on patch set 2 V +1 01/05/22, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21670

  6. Stefan Bürk wrote 01/05/22, 22:21

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  7. Stefan Bürk wrote 01/05/22, 22:21

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  8. Stefan Bürk updated the commit message in patch set 3 01/05/22, 22:22

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 01/05/22, 22:22

  10. core-ci voted on patch set 3 V +1 01/05/22, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21671

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 01/05/22, 22:43

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 01/05/22, 22:45

  13. Oli Bartsch merged patch set 4 01/05/22, 22:45