Review main Merged

72869[BUGFIX] Ensure correct test expectation for hierarchicalMenuIsGenerated

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 01/06/22, 00:27

Commit message

Merging #22190 shortly after #96470 has introduced a invalid
test case expectation, which fails now core ci execution.

This patch adds a missing 'target' expectation for the test
added through #22190 to match introduced expectation with #96470.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 01/06/22, 00:11

  2. core-ci voted on patch set 1 V +1 01/06/22, 00:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21678

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/06/22, 00:25

  4. Oli Bartsch commented on patch set 1 V +2 CR +2 01/06/22, 00:27

    I'm exceptionally merging this followup directly to prevent upcoming nightlies from failing and because this is a no-brainer, which occurred due to merging two patches, targeting the same test case data provider.
  5. Oli Bartsch merged patch set 2 01/06/22, 00:27