Review main Merged

72871[BUGFIX] Use typolink consistently for makelinks functionality

Benni Mack CR +2 V +2 Normal +13 −39 updated 01/06/22, 15:12

Commit message

TYPO3's "makelinks" functionality parses for in-text
external URLs and mailto links. This change uses
Typolink under the hood now to consistently check
for invalid content, and have the chance to use
all hooks in typolink for such links as well.

This way, typolink is used, but makelinks is
executed AFTER possible resolved <a> tags
avoiding double-calling parseFunc when <a> tag
processing is configured.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Benni Mack uploaded patch set 1 01/06/22, 13:35

  2. Benni Mack uploaded patch set 2 01/06/22, 13:47

  3. Benni Mack commented on patch set 3 01/06/22, 13:47

    Published edit on patch set 2.
  4. core-ci voted on patch set 1 V +1 01/06/22, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21698

  5. core-ci voted on patch set 2 V +1 01/06/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21700

  6. core-ci voted on patch set 3 V +1 01/06/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21701

  7. Oli Bartsch uploaded patch set 4 01/06/22, 14:49

  8. Oli Bartsch uploaded patch set 5 01/06/22, 14:51

  9. Oli Bartsch voted on patch set 5 V +1 CR +1 01/06/22, 14:51

  10. Stefan Bürk voted on patch set 5 CR +1 01/06/22, 15:01

  11. core-ci voted on patch set 4 V -1 01/06/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21707

  12. core-ci voted on patch set 5 V +1 01/06/22, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21709

  13. Stefan Bürk voted on patch set 5 V +1 01/06/22, 15:10

  14. Benni Mack voted on patch set 5 V +2 CR +2 01/06/22, 15:12

  15. Benni Mack merged patch set 6 01/06/22, 15:12