72892[TASK] Separate JavaScriptHandler concerns
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 20
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/FlexFormSectionContainer.ts+3 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/InlineRelation/AjaxDispatcher.ts+3 −2
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/JavaScriptItemHandler.tsnew+29 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/JavaScriptItemProcessor.tsnew+157 −0
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/RequireJSConfigHandler.tsnew+25 −0
- Build/types/TYPO3/index.d.ts+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/FlexFormSectionContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/InlineRelation/AjaxDispatcher.js+1 −1
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+4 −20
- typo3/sysext/core/Classes/Page/PageRenderer.php+9 −11
- typo3/sysext/core/Classes/Page/RequireJS.phpdeleted+0 −65
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-96136-DeprecateInlineJavaScriptInBackendUpdateSignals.rst+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptHandler.jsdeleted+0 −197
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptItemHandler.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptItemProcessor.jsnew+13 −0
- typo3/sysext/core/Resources/Public/JavaScript/RequireJSConfigHandler.jsnew+13 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+1 −0
- typo3/sysext/core/Tests/Functional/Page/JavaScriptRendererTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+1 −1
Review log 1420
-
Benjamin Franzke uploaded patch set 1 01/06/22, 14:02
-
core-ci voted on patch set 1 V -1 01/06/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21702
-
Benjamin Franzke uploaded patch set 2 01/06/22, 14:23
-
core-ci voted on patch set 2 V -1 01/06/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21704
-
Benjamin Franzke uploaded patch set 3 01/06/22, 15:07
-
core-ci voted on patch set 3 V -1 01/06/22, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21710
-
Benjamin Franzke uploaded patch set 4 01/06/22, 15:26
-
core-ci voted on patch set 4 V -1 01/06/22, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21714
-
Benjamin Franzke uploaded patch set 5 01/06/22, 15:57
-
core-ci voted on patch set 5 V +1 01/06/22, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21715
-
Benjamin Franzke uploaded patch set 6 01/06/22, 18:50
-
core-ci voted on patch set 6 V +1 01/06/22, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21729
-
Benjamin Franzke commented on patch set 6 01/06/22, 20:17
Note, Please following WIP change for possible future ES6 module integration: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72637/19/Build/Sources/TypeScript/core/Resources/Public/TypeScript/JavaScriptItemProcessor.ts (Therefore module loading is moved into a separate function and already uses Promise, makes later patches easier to integrate) -
Benni Mack commented on patch set 6 01/06/22, 23:15
Looks good on reading, but I guess we'd need Olly Haders' input on this as well. -
Benjamin Franzke commented on patch set 6 01/07/22, 06:01
Reply
yeah, would be great. thanks for cc'ing him, I was unsure because of possible holidays. -
Oliver Hader voted on patch set 6 CR +1 01/10/22, 13:49
-
Oliver Hader voted on patch set 6 V +1 01/10/22, 14:03
-
Benni Mack voted on patch set 6 V +1 CR +1 01/10/22, 15:06
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 01/10/22, 15:31
-
Benjamin Franzke merged patch set 7 01/10/22, 15:32