Review main Merged

72893[BUGFIX] Ensure config.spamProtectEmailAddresses = ascii works for external URLs

Benni Mack CR +2 V +2 Easy +42 −1 updated 01/06/22, 22:10

Commit message

When having a page of type "External URL", set to
an email address, and config.spamProtectEmailAddresses = ascii
set in TypoScript, the encoding now works properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Benni Mack uploaded patch set 1 01/06/22, 14:51

  2. core-ci voted on patch set 1 V +1 01/06/22, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21708

  3. Benni Mack commented on patch set 1 CR -1 01/06/22, 15:25

    I think we should add a test-case for this...
  4. Benni Mack uploaded patch set 2 01/06/22, 16:09

  5. core-ci voted on patch set 2 V -1 01/06/22, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21717

  6. Benni Mack uploaded patch set 3 01/06/22, 16:32

  7. core-ci voted on patch set 3 V +1 01/06/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21720

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 01/06/22, 19:11

  9. Oli Bartsch uploaded patch set 4 01/06/22, 21:49

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 01/06/22, 21:50

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 01/06/22, 21:51

  12. core-ci voted on patch set 4 V +1 01/06/22, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21736

  13. Benni Mack voted on patch set 4 V +2 CR +2 01/06/22, 22:10

  14. Benni Mack merged patch set 5 01/06/22, 22:10