Review main Merged

72894[BUGFIX] TypoLink is executed fully without href attribute

Benni Mack CR +2 V +2 Normal +76 −31 updated 01/06/22, 23:02

Commit message

In #87992 an early return was added to have <a> tags
with just an "id" or "name" attribute. This is all nice,
but when used further typolink settings (such as userFunc
or custom "title"), these options were never run.

This change now uses typolink() natively again and
removes the introduced "resolveAnchorLinK" workaround.

Added tests show that additional attributes are executed
and links without href are actually created (was previously
untested).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 01/06/22, 19:38

  2. core-ci voted on patch set 1 V -1 01/06/22, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21731

  3. Benni Mack uploaded patch set 2 01/06/22, 20:44

  4. core-ci voted on patch set 2 V +1 01/06/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21734

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 01/06/22, 22:51

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 01/06/22, 22:55

  7. Benni Mack voted on patch set 2 V +2 CR +2 01/06/22, 23:02

  8. Benni Mack merged patch set 3 01/06/22, 23:02