Review main Merged

72896[TASK] Ensure ATagParams are overridden from global option

Benni Mack CR +2 V +2 Normal +114 −3 updated 01/06/22, 22:41

Commit message

This change mainly adds tests for showing that
the global TypoScript option

  config.ATagParams = tabindex="20"

can be used and any given attributes are actually
overridden if using typolink.ATagParams = tabindex="13".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 01/06/22, 22:10

  2. Benni Mack updated the commit message in patch set 2 01/06/22, 22:10

  3. core-ci voted on patch set 1 V -1 01/06/22, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21738

  4. core-ci voted on patch set 2 V +1 01/06/22, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21739

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 01/06/22, 22:32

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 01/06/22, 22:41

  7. Oli Bartsch merged patch set 3 01/06/22, 22:41