Review main Merged

72897[BUGFIX] Use typolink in EmailViewHelper

Benni Mack CR +2 V +2 Easy +21 −7 updated 01/10/22, 10:53

Commit message

This change uses typolink in EmailViewHelper,
allowing to also use typolink hooks or custom
Email Link Builder to be used consistently
across TYPO3 Core (e.g. using the same hooks
for all email link generation in the Frontend).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1424

  1. Benni Mack uploaded patch set 1 01/06/22, 23:44

  2. core-ci voted on patch set 1 V -1 01/06/22, 23:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21746

  3. Benni Mack uploaded patch set 2 01/07/22, 13:32

  4. core-ci voted on patch set 2 V -1 01/07/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21773

  5. Benni Mack uploaded patch set 3 01/07/22, 13:48

  6. core-ci voted on patch set 3 V -1 01/07/22, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21774

  7. Benni Mack uploaded patch set 4 01/07/22, 21:00

  8. core-ci voted on patch set 4 V -1 01/07/22, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21786

  9. Benni Mack uploaded patch set 5 01/08/22, 12:39

  10. core-ci voted on patch set 5 V -1 01/08/22, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21810

  11. Benni Mack uploaded patch set 6 01/08/22, 19:09

  12. core-ci voted on patch set 6 V -1 01/08/22, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21813

  13. core-ci commented on patch set 6 01/08/22, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21813

  14. Benni Mack updated the commit message in patch set 7 01/09/22, 12:27

  15. core-ci voted on patch set 7 V -1 01/09/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21819

  16. Benni Mack uploaded patch set 8 01/09/22, 12:54

  17. Benni Mack commented on patch set 9 01/09/22, 13:08

    Published edit on patch set 8.
  18. core-ci voted on patch set 8 V -1 01/09/22, 13:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21820

  19. core-ci voted on patch set 9 V +1 01/09/22, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21823

  20. Jörg Bösche voted on patch set 9 CR +1 01/09/22, 20:32

  21. Oli Bartsch voted on patch set 9 V +1 CR +1 01/10/22, 10:21

  22. Stefan Bürk voted on patch set 9 V +1 CR +1 01/10/22, 10:47

  23. Benni Mack voted on patch set 9 V +2 CR +2 01/10/22, 10:53

  24. Benni Mack merged patch set 10 01/10/22, 10:53