Review main Merged

72898[TASK] Clean up Page Link Builder code

Benni Mack CR +2 V +2 Hard +239 −191 updated 01/10/22, 10:20

Commit message

During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monster-method.

Now, that most bugs are solved and we have a very good
test coverage for this, this change splits several
functionality into smaller methods, allowing for better
readability, extensibility and further refactoring.

Extending PageLinkBuilder now is much easier to replace
a certain part of the existing functionality (also via XCLASS).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 01/07/22, 00:36

  2. core-ci voted on patch set 1 V +1 01/07/22, 00:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21748

  3. Oli Bartsch voted on patch set 1 CR +1 01/07/22, 16:48

  4. Benni Mack uploaded patch set 2 01/07/22, 21:10

  5. core-ci voted on patch set 2 V +1 01/07/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21787

  6. Stefan Bürk voted on patch set 2 CR +1 01/08/22, 12:17

  7. Stefan Bürk voted on patch set 2 V +1 01/08/22, 12:58

  8. Andreas Kienast voted on patch set 2 CR +1 01/08/22, 14:41

  9. Jörg Bösche voted on patch set 2 CR +1 01/09/22, 20:33

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 01/10/22, 10:15

  11. Benni Mack voted on patch set 2 V +2 CR +2 01/10/22, 10:20

  12. Benni Mack merged patch set 3 01/10/22, 10:20