Review main Merged

72900[BUGFIX] Fix sprintf() PHP warning in FinisherOptionGenerator

Benjamin Franzke CR +2 V +2 Easy +4 −6 updated 01/07/22, 13:13

Commit message

User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more likely) %20S
(which is ' S' url escaped) may be contained and cause warnings
because sprintf() expects additional arguments in that case.

Streamline to always use the static '%s: "%s"' format instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 01/07/22, 08:16

  2. core-ci voted on patch set 1 V +1 01/07/22, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21754

  3. Andreas Kienast voted on patch set 1 CR +1 01/07/22, 09:04

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 01/07/22, 11:55

  5. Benni Mack voted on patch set 1 V +1 CR +1 01/07/22, 12:55

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/07/22, 13:13

  7. Benjamin Franzke merged patch set 2 01/07/22, 13:13