Review 10.4 Merged

72901[BUGFIX] Fix sprintf() PHP warning in FinisherOptionGenerator

Benjamin Franzke CR +2 V +2 Easy +4 −3 updated 01/07/22, 13:14

Commit message

User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more likely) %20S
(which is ' S' url escaped) may be contained and cause warnings
because sprintf() expects additional arguments in that case.

Streamline to always use the static '%s: "%s"' format instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 01/07/22, 08:21

  2. core-ci voted on patch set 1 V +1 01/07/22, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21755

  3. Benjamin Franzke commented on patch set 1 V +2 CR +2 01/07/22, 13:13

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 01/07/22, 13:14