72903[BUGFIX] Load navigation frame src after transformations are done
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1114
-
Andreas Kienast uploaded patch set 1 01/07/22, 12:46
-
Andreas Kienast updated the commit message in patch set 2 01/07/22, 12:49
-
core-ci voted on patch set 1 V +1 01/07/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21765
-
core-ci voted on patch set 2 V +1 01/07/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21766
-
Oli Bartsch voted on patch set 2 V +1 CR +1 01/07/22, 13:17
-
Benjamin Franzke commented on patch set 2 01/07/22, 13:20
-
Andreas Kienast commented on patch set 2 CR -1 01/07/22, 13:59
on itNavigationContainer.ts:88Replyfine with me -
Benjamin Franzke commented on patch set 2 CR -1 01/07/22, 14:04
NavigationContainer.ts:88ReplyHm, also the transitionend we receive here is from <div class="bar" role="bar" - which is provided by nprogress. I guess that means we basically have a random timeout here, but don't really wait for any transition that actually affects the iframe. Becuase, as far as I see, there is no transition for the class="scaffold" element, nor for any element that is parent of the navigation frame, right? This means the navigation iframe is actually slowed-down until the content frame is loaded (nprogress ended). I unfortunately can not reproduce the issue in firefox under linux. Did you with Windows or MacOS? I wonder if a slight delay, e.g. using `requestAnimationFrame()` also fixes the issue? -
Andreas Kienast uploaded patch set 3 01/07/22, 14:12
-
Andreas Kienast commented on patch set 3 01/07/22, 14:16
NavigationContainer.ts:88ReplyI was able to reproduce it with Firefox on Ubuntu. The important thing is to open the Filelist module right after logging in into the backend, before any navigation frame is opened. Also, make sure you're testing this in 10.4 ;) -
core-ci voted on patch set 3 V +1 01/07/22, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21775
-
Andreas Kienast commented on patch set 3 01/07/22, 14:30
NavigationContainer.ts:88ReplyUnfortunately, requestAnimationFrame() isn't sufficient here in all cases. Plus, the setTimeout() workaround also fails then. -
Benjamin Franzke commented on patch set 3 01/08/22, 09:31
NavigationContainer.ts:88Reply UnresolvedYea, I tested with 10.4 and Firefox 95 under linux and couldn't reproduce. Anyway, Firefox 95 on windows 10 failed for me as well. And I think this is actually a race caused by our ModuleMenu code that cals both, setUrl() and refresh(). This causes Firefox to abort the request, therefore `about:blank` is kept. Please see the following patch for another way to fix this (works for me with Firefox on Windows 10): https://review.typo3.org/c/Packages/TYPO3.CMS/+/72932 -
Andreas Kienast abandoned the change 01/08/22, 13:01
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72932
NavigationContainer.ts:88