Review main Merged

72905[BUGFIX] Exclude pages from linkvalidator path

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 01/10/22, 11:51

Commit message

The linkvalidator module shows the path to the page,
a broken link is on. Since editors might only have access
to a subtree (mount point), the corresponding parent
pages should not be displayed.

This is now fixed by providing the necessary permission
clause to `getRecordPath` in LinkValidatorController.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Oli Bartsch uploaded patch set 1 01/07/22, 15:23

  2. core-ci voted on patch set 1 V +1 01/07/22, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21779

  3. Stefan Bürk voted on patch set 1 CR +1 01/07/22, 15:55

  4. Stefan Bürk commented on patch set 1 01/08/22, 11:54

    Thanks for this patch, Oliver. But I think this is not a real, or at least not the complete solution for the forge issue. Given a user group. Pages set this group on all pages/page levels. user1 has a mointpoint on a subpage and is in this group. Your patch will not change the page as the usergroup has acces right on the mointpoint paren, even if not "visible" because of the mointpoint. Removing or change the "group" acces on the mountpoint parent page will remove this from the path.
  5. Benni Mack voted on patch set 1 V +1 CR +1 01/10/22, 10:22

  6. Oli Bartsch commented on patch set 1 01/10/22, 10:23

    Reply

    So isn't this then a misconfiguration of the page access permissions?
  7. Stefan Bürk commented on patch set 1 V +1 01/10/22, 10:28

    Reply

    Under this point I'm fine with it.
  8. Oli Bartsch voted on patch set 1 V +2 CR +2 01/10/22, 11:51

  9. Oli Bartsch merged patch set 2 01/10/22, 11:51