72908[!!!][TASK] Remove config.spamProtectEmailAddresses = ascii
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Froemken +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-90044-ConfigspamProtectEmailAddressesWithOptionAsciiRemoved.rstnew+45 −0
- typo3/sysext/core/Tests/Functional/Html/DefaultSanitizerBuilderTest.php+0 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+4 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+0 −16
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php5+25 −38
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+7 −5
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+0 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+0 −34
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+8 −72
- typo3/sysext/t3editor/Resources/Private/tsref.xml+4 −12
Review log 1723
-
Benni Mack uploaded patch set 1 01/07/22, 21:43
-
core-ci voted on patch set 1 V -1 01/07/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21791
-
Benni Mack uploaded patch set 2 01/10/22, 18:23
-
core-ci voted on patch set 2 V -1 01/10/22, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21869
-
Benni Mack uploaded patch set 3 01/10/22, 18:39
-
core-ci voted on patch set 3 V +1 01/10/22, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21871
-
Benni Mack uploaded patch set 4 01/10/22, 19:57
-
core-ci voted on patch set 4 V +1 01/10/22, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21874
-
Benni Mack commented on patch set 5 01/10/22, 20:34
Published edit on patch set 4. -
Stefan Froemken commented on patch set 5 V -1 CR -1 01/10/22, 20:38
TypoScriptFrontendController.php:2960Please don't do that. I've tested that: It results in "TYPO3 Deprecation Notice: TypoScript property config.spamProtectEmailAddresses = ascii is deprecated - This setting has no effect anymore." and adds 2 spaces because of ' - ' two lines above. -
Stefan Froemken commented on patch set 5 01/10/22, 20:41
Luckily emailobfuscator does not require spamProtectEmailAddresses to be "ascii": https://github.com/zotornit/t3x-emailobfuscator/blob/e8223140302670d655b027ba5a274ddb571e4807/Classes/Hook/ObfuscationHook.php#L68-L73 Else, emailobfuscator would not work because of your int-casts ;-) So mention emailobfuscator here is OK for me. -
core-ci voted on patch set 5 V +1 01/10/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21876
-
Benni Mack commented on patch set 5 01/10/22, 20:51
TypoScriptFrontendController.php:2960Replythanks, will adapt. -
Benni Mack commented on patch set 6 01/10/22, 20:51
Published edit on patch set 5. -
Benni Mack commented on patch set 6 01/10/22, 20:52
Reply
This code checks for the actual TypoScript option, not on the TSFE property. -
Stefan Froemken commented on patch set 6 V +1 CR +1 01/10/22, 20:55
TypoScriptFrontendController.php:2960ReplyAck -
core-ci voted on patch set 6 V +1 01/10/22, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21878
-
Oli Bartsch voted on patch set 6 V +1 01/10/22, 22:03
-
Oli Bartsch commented on patch set 6 01/10/22, 22:11
ContentObjectRenderer.php:5015Could be removed as the property has a type hint int.ContentObjectRenderer.php:5018Same here -
Benni Mack commented on patch set 6 01/11/22, 08:09
ContentObjectRenderer.php:5015Replywill do that with the next patch then, OK? https://review.typo3.org/c/Packages/TYPO3.CMS/+/72944 -
Oli Bartsch commented on patch set 6 CR +1 01/11/22, 10:16
ContentObjectRenderer.php:5015ReplyAckContentObjectRenderer.php:5018ReplyAck -
Benni Mack voted on patch set 6 V +2 CR +2 01/11/22, 10:46
-
Benni Mack merged patch set 7 01/11/22, 10:46