Review main Merged Breaking

72908[!!!][TASK] Remove config.spamProtectEmailAddresses = ascii

Benni Mack CR +2 V +2 Hard +93 −194 updated 01/11/22, 10:46

Commit message

Since modern browsers already decode this "security"
measure, the option config.spamProtectEmailAddresses = ascii
is removed from TYPO3 Core.

Existing installations having the option set to "ascii"
will now behave as this option would be set to "0" (= disabled).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1723

  1. Benni Mack uploaded patch set 1 01/07/22, 21:43

  2. core-ci voted on patch set 1 V -1 01/07/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21791

  3. Benni Mack uploaded patch set 2 01/10/22, 18:23

  4. core-ci voted on patch set 2 V -1 01/10/22, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21869

  5. Benni Mack uploaded patch set 3 01/10/22, 18:39

  6. core-ci voted on patch set 3 V +1 01/10/22, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21871

  7. Benni Mack uploaded patch set 4 01/10/22, 19:57

  8. core-ci voted on patch set 4 V +1 01/10/22, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21874

  9. Benni Mack commented on patch set 5 01/10/22, 20:34

    Published edit on patch set 4.
  10. Stefan Froemken commented on patch set 5 V -1 CR -1 01/10/22, 20:38

    TypoScriptFrontendController.php:2960

    Please don't do that. I've tested that: It results in "TYPO3 Deprecation Notice: TypoScript property config.spamProtectEmailAddresses = ascii is deprecated - This setting has no effect anymore." and adds 2 spaces because of ' - ' two lines above.
  11. Stefan Froemken commented on patch set 5 01/10/22, 20:41

    Luckily emailobfuscator does not require spamProtectEmailAddresses to be "ascii": https://github.com/zotornit/t3x-emailobfuscator/blob/e8223140302670d655b027ba5a274ddb571e4807/Classes/Hook/ObfuscationHook.php#L68-L73 Else, emailobfuscator would not work because of your int-casts ;-) So mention emailobfuscator here is OK for me.
  12. core-ci voted on patch set 5 V +1 01/10/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21876

  13. Benni Mack commented on patch set 5 01/10/22, 20:51

    TypoScriptFrontendController.php:2960 Reply

    thanks, will adapt.
  14. Benni Mack commented on patch set 6 01/10/22, 20:51

    Published edit on patch set 5.
  15. Benni Mack commented on patch set 6 01/10/22, 20:52

    Reply

    This code checks for the actual TypoScript option, not on the TSFE property.
  16. Stefan Froemken commented on patch set 6 V +1 CR +1 01/10/22, 20:55

    TypoScriptFrontendController.php:2960 Reply

    Ack
  17. core-ci voted on patch set 6 V +1 01/10/22, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21878

  18. Oli Bartsch voted on patch set 6 V +1 01/10/22, 22:03

  19. Oli Bartsch commented on patch set 6 01/10/22, 22:11

    ContentObjectRenderer.php:5015

    Could be removed as the property has a type hint int.

    ContentObjectRenderer.php:5018

    Same here
  20. Benni Mack commented on patch set 6 01/11/22, 08:09

    ContentObjectRenderer.php:5015 Reply

    will do that with the next patch then, OK? https://review.typo3.org/c/Packages/TYPO3.CMS/+/72944
  21. Oli Bartsch commented on patch set 6 CR +1 01/11/22, 10:16

    ContentObjectRenderer.php:5015 Reply

    Ack

    ContentObjectRenderer.php:5018 Reply

    Ack
  22. Benni Mack voted on patch set 6 V +2 CR +2 01/11/22, 10:46

  23. Benni Mack merged patch set 7 01/11/22, 10:46