Review main Merged

72909[BUGFIX] HMENU: Use ATagParams directly from typolink

Benni Mack CR +2 V +2 Easy +11 −2 updated 01/14/22, 18:49

Commit message

When setting "HMENU.1.NO.ATagParams" then "ATagParams"
called in cObj->ATagParams is now processed once by
setting the option in typolink().

This way, any hooks in ATagParams are added within
the context of the typolink function, also receiving
all information in the LinkResult object. This is
now possible with TYPO3 v11.

Some workarounds are needed and document on how
to clean this functionality up in TYPO3 v12+.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Benni Mack uploaded patch set 1 01/07/22, 22:07

  2. Benni Mack updated the commit message in patch set 2 01/07/22, 22:09

  3. core-ci voted on patch set 1 V -1 01/07/22, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21794

  4. core-ci voted on patch set 2 V -1 01/07/22, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21795

  5. Benni Mack uploaded patch set 3 01/08/22, 12:37

  6. core-ci voted on patch set 3 V +1 01/08/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21809

  7. Jörg Bösche voted on patch set 3 CR +1 01/09/22, 20:34

  8. Benni Mack updated the commit message in patch set 4 01/13/22, 21:15

  9. core-ci voted on patch set 4 V +1 01/13/22, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22045

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 01/14/22, 18:06

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 01/14/22, 18:48

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 01/14/22, 18:49

  13. Christian Kuhn merged patch set 5 01/14/22, 18:49